-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Spanish Translation: Copyable/Editable/AddRemove/SearchBar/PreviewNav #1569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…iew_assets # Conflicts: # translations/locales/en-US/translations.json # translations/locales/es-419/translations.json
…d_preview_assets # Conflicts: # translations/locales/en-US/translations.json # translations/locales/es-419/translations.json
… into add_preview_assets # Conflicts: # translations/locales/en-US/translations.json # translations/locales/es-419/translations.json
…into add_preview_assets # Conflicts: # translations/locales/en-US/translations.json # translations/locales/es-419/translations.json
…iew_assets # Conflicts: # translations/locales/en-US/translations.json # translations/locales/es-419/translations.json
@andrewn Can you have a look at this, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of minor naming things, then this is good to go!
…_prevNav # Conflicts: # translations/locales/en-US/translations.json # translations/locales/es-419/translations.json
@andrewn The issues were addressed, can you have a look, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks!
@oruburos can you fix the conflict and then I'll merge. Thanks! |
…_prevNav # Conflicts: # translations/locales/es-419/translations.json
@andrewn Conflicts solved, can you have a look at this, please? |
I have verified that this pull request:
npm run lint
)